Skip to content

[fatdrvce] converted division by a power of two into a bitshift#791

Merged
mateoconlechuga merged 6 commits intomasterfrom
fatdrvce_use_shift
May 1, 2026
Merged

[fatdrvce] converted division by a power of two into a bitshift#791
mateoconlechuga merged 6 commits intomasterfrom
fatdrvce_use_shift

Conversation

@ZERICO2005
Copy link
Copy Markdown
Contributor

@ZERICO2005 ZERICO2005 commented Apr 18, 2026 •
edited
Loading

TL:DR turns 32bit division into a bitshift

Resolves #757

@mateoconlechuga mateoconlechuga self-assigned this Apr 18, 2026
runer112
runer112 reviewed Apr 18, 2026
View reviewed changes
Comment thread src/fatdrvce/fatdrvce.asm Outdated
calc84maniac
calc84maniac reviewed Apr 19, 2026
View reviewed changes
Comment thread src/fatdrvce/fatdrvce.asm
@ZERICO2005
Copy link
Copy Markdown
Contributor Author

ZERICO2005 commented Apr 20, 2026

Unrelated, but I noticed that ret is unreachable here?

	adc	a,b
	jq	.traversefat
	ret
.unallocatedcluster:
	ld	a,128

@mateoconlechuga mateoconlechuga marked this pull request as ready for review May 1, 2026 15:05
@mateoconlechuga mateoconlechuga merged commit a5d47dd into master May 1, 2026
9 checks passed
@mateoconlechuga mateoconlechuga deleted the fatdrvce_use_shift branch May 1, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calc84maniac calc84maniac calc84maniac left review comments

@runer112 runer112 runer112 left review comments

Assignees

@mateoconlechuga mateoconlechuga

Labels

lib/fatdrvce

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

division/remainder can be replaced with bitshifts in fatdrvce

4 participants

@ZERICO2005 @calc84maniac @runer112 @mateoconlechuga